Increase progress and link#94
Merged
Merged
Conversation
m-aciek
requested changes
Jun 19, 2025
m-aciek
left a comment
m-aciek
left a comment
Collaborator
There was a problem hiding this comment.
I think that word-based completion change better expresses the real translation work done, than a string-based completion.
Word completion is not available in potodo, and a bit harder to calculate than the string-based. Maybe that's why it's not popular.
I would insist on keeping the word-based completion.
Maybe it would be fine to have two badges?
- total (words)
- total (strings)
Co-authored-by: Maciej Olko <maciej.olko@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems that using strings is more popular, e.g. the dashboard. Linking to the dashboard home for now, it will be nice to link to the details page once that is complete;-)